-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internals: use of TASK_OUTPUTs and TASK_EVENTs in task_event_mgr #6002
Comments
What is the problem with how it is currently? |
There are four related things:
Whilst working on #5658 it was discovered that triggers/messages were sometimes mislabelled as their opposite and outputs was sometimes used ambiguously to refer to one or the other. No functional problems, it all works fine, just confusing when you need to work on this code. Cheat Sheet:
|
I've been diving into this code over the past few days whilst working on the optional outputs and struggling with this a bit (completion expressions need triggers, most of the rest of the code needs messages, trying to avoid storing surplus maps whilst keeping it efficient). I'm coming to the conclusion that messages should be mapped onto triggers in the task events code, from there on it would be simpler to stick to triggers. Triggers are the more fundamental and user facing concept. They are used in the graph, the completion expression, |
Noticed while working on #5658
Straighten out the use of
TASK_OUTPUT_blah
vsTASK_EVENT_blah
in the event manager module.It works fine as-is, because the standard OUTPUT and EVENT names are the same, but we should still use the correct constants for clarity.
The text was updated successfully, but these errors were encountered: