Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests should not create symlinks #5988

Open
wxtim opened this issue Feb 22, 2024 · 1 comment
Open

Integration tests should not create symlinks #5988

wxtim opened this issue Feb 22, 2024 · 1 comment
Labels
small
Milestone
8.x

Comments

@wxtim
Copy link
Member

wxtim commented Feb 22, 2024 •
edited
Loading

(Unless install symlink creation is under test)

The tests in tests/integration/test_install.py rely on the user disabling Symlink creation in thier global config to pass reliably, else they fail on second run becuase the previous run is not cleaned correctly.

Should we disable symlink installs in integration tests unless actively required?

Note

This bug is not user facing, and with correct setup of the global.cylc shouldn't affect developers most of the time -> Low priority.
@wxtim wxtim added bug Something is wrong :( question Flag this as a question for the next Cylc project meeting. labels Feb 22, 2024
@wxtim wxtim added this to the cylc-8.x milestone Feb 22, 2024
@oliver-sanders oliver-sanders removed question Flag this as a question for the next Cylc project meeting. bug Something is wrong :( labels Feb 22, 2024
@oliver-sanders
Copy link
Member

(removing bug label because, as you say, it's not user-facing)

Enough just to patch the remaining (2?) tests that still do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small
Projects
None yet
Milestone
8.x
Development

No branches or pull requests
2 participants
@oliver-sanders @wxtim