Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: python 3.10 #5736

Open
oliver-sanders opened this issue Sep 19, 2023 · 2 comments
Open

mypy: python 3.10 #5736

oliver-sanders opened this issue Sep 19, 2023 · 2 comments
Milestone
some-day

Comments

@oliver-sanders
Copy link
Member

Mypy appears to be raising false positives in imported code for Python 3.10 , so currently, we're only running it for Python 3.9.

We will need to address this going forward.

The problem:

  • Matplotlib has dropped Python 3.7 support in their latest releases.
  • MyPy is complaining for non 3.7 compatible syntax in the non 3.7 compatible matplotlib code.
  • But these non compatible versions shouldn't get installed for 3.7 anyway (the install tool should handle this).
  • Adding an upper pin for Matplotlib which only applies to Python 3.7 doesn't make this go away.

Because no_silence_site_packages=false (the default) I wouldn't expect any errors from imported code anyway?

See #5735
@oliver-sanders oliver-sanders added this to the some-day milestone Sep 19, 2023
@oliver-sanders oliver-sanders mentioned this issue Sep 19, 2023
Merged
@MetRonnie
Copy link
Member

python/mypy#9972

I don't think we can do anything about this

@oliver-sanders
Copy link
Member Author

Ok, I guess we'll stick with 3.9 for linting until we are able to drop 3.7 support. Bit of a pain for development, but easy to achieve in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
some-day
Development

No branches or pull requests
2 participants
@oliver-sanders @MetRonnie