Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handler events list not validated #2756

Open
hjoliver opened this issue Aug 16, 2018 · 1 comment
Open

handler events list not validated #2756

hjoliver opened this issue Aug 16, 2018 · 1 comment
Assignees
@hjoliver
Labels
bug Something is wrong :(
Milestone
8.x

Comments

@hjoliver
Copy link
Member

For generic event handlers, the handler events list (in task config) is not checked for validity. We should have a list of all valid event names held in one place, in task_events_mgr.py, and then simply use that as an option list in the suite config spec.
@hjoliver hjoliver added bug? Not sure if this is a bug or not small labels Aug 16, 2018
@hjoliver hjoliver added this to the later milestone Aug 16, 2018
@hjoliver hjoliver self-assigned this Aug 16, 2018
@hjoliver hjoliver added bug Something is wrong :( and removed bug? Not sure if this is a bug or not labels Aug 16, 2018
This was referenced Oct 17, 2018
Closed
Merged
@matthewrmshin
Copy link
Contributor

Note: task event handlers can now handle custom task outputs, so this is a bit more complex.

@matthewrmshin matthewrmshin modified the milestones: later, cylc-9 Aug 28, 2019
@hjoliver hjoliver mentioned this issue Jul 19, 2022
Closed
@dpmatthews dpmatthews modified the milestones: cylc-9, cylc-8.x Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjoliver hjoliver

Labels
bug Something is wrong :(
Projects
None yet
Milestone
8.x
Development

No branches or pull requests
3 participants
@dpmatthews @matthewrmshin @hjoliver