Use schema modifiers as mutable #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded into Entity definition
roxblnfk
force-pushed
the
modifiers-clones
branch
from
8042cb4
to
2e02c47
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #75 /- ##
=========================================
Coverage 94.90% 94.90%
Complexity 590 590
=========================================
Files 45 45
Lines 1667 1669 2
=========================================
Hits 1582 1584 2
Misses 85 85 ☔ View full report in Codecov by Sentry. |
roxblnfk
force-pushed
the
modifiers-clones
branch
from
5bfd5ad
to
e618563
Compare
msmakouz
approved these changes
Jul 10, 2024
roxblnfk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
Call modifier's
withRole()method at the same moment when they are added into Entity definition.An exception will be thrown when a modifier is added to an entity without role
🤔 Why?
To not to rewrite all the stateful behaviors
📝 Checklist