attributes bug fix #100
Open
attributes bug fix #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to our conversation before :
Thank you Audai! Can you send a pull request on Github and I will merge it?
Carl
On Mon, Jan 23, 2017 at 5:59 AM Audai Shmalih [email protected] wrote:
Hi Carl,
I'm using your amazing Vatic system, and I found a bug when you have attributes and want to export the annotaions in json format it's failed!
I fixed the bug by doing some changes in vatic/cli.py
change the line 683:
boxdata['attributes'] = box.attributes
to
boxdata['attributes'] = []
for attr in box.attributes:
boxdata['attributes'].append(attr.text)