In conversion from musicXML, allow multiple {Fret/String}Indications for chord. #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gIndications for chord.
|
Great! In the future please try to add a test, but this is pretty complex code, and your solution will work. The inner notes of a chord have an articulations class, and we should be adding the indications there too, but that's a major refactor that I don't want to do now. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to access frets and string information in guitar tablatures for chords after conversion from musicXML, because StringIndication and FretIndication objects are stored in chord.articulation property only for a single (lowest) note of a chord.
E.g., when running the attached example with very simple musicXML, expected:
<music21.chord.Chord D3 A3 D4 F4 A4> [<music21.articulations.FretIndication 5>, <music21.articulations.StringIndication 5>, <music21.articulations.FretIndication 7>, <music21.articulations.StringIndication 4>, <music21.articulations.FretIndication 7>, <music21.articulations.StringIndication 3>, <music21.articulations.FretIndication 6>, <music21.articulations.StringIndication 2>, <music21.articulations.FretIndication 5>, <music21.articulations.StringIndication 1>]but have only:
<music21.chord.Chord D3 A3 D4 F4 A4> [<music21.articulations.FretIndication 5>, <music21.articulations.StringIndication 5>]chord_test.zip
Suggested fix is following already established path, i.e., similar to excluding articulations.Fingering from articulations uniqueness check.