Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for delayed turns (and delayed inverted turns). #1533

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Add support for delayed turns (and delayed inverted turns). #1533

merged 4 commits into from
Feb 27, 2023

Conversation

gregchapman-dev
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 24, 2023 •
edited
Loading

Coverage Status

Coverage: 93.07% ( 0.0009%) from 93.069% when pulling 1e3d65c on gregchapman-dev:gregc/delayedTurns into c8653e4 on cuthbertLab:master.

@gregchapman-dev
Copy link
Contributor Author

Hoping this can make v9 as well.

@gregchapman-dev gregchapman-dev mentioned this pull request Feb 24, 2023
Closed
mscuthbert
mscuthbert requested changes Feb 25, 2023
View reviewed changes
Copy link
Member

@mscuthbert mscuthbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is GREAT! There is one substantive issue (last comment) that needs to be addressed about float delays, and a few style things, but hope I can get this in today. Thanks!

music21/expressions.py Outdated Show resolved Hide resolved
music21/expressions.py Show resolved Hide resolved
music21/expressions.py Outdated Show resolved Hide resolved
music21/musicxml/m21ToXml.py Show resolved Hide resolved
music21/test/test_expressions.py Show resolved Hide resolved
music21/test/test_expressions.py Outdated Show resolved Hide resolved
@gregchapman-dev
Copy link
Contributor Author

Assuming all the checks pass, this should be ready to go.

@gregchapman-dev
Copy link
Contributor Author

@mscuthbert Checks have passed, looks ready to go.

@mscuthbert
Copy link
Member

Great. Will be in the office later today and looks like it's a ready to merge.

mscuthbert
mscuthbert approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@mscuthbert mscuthbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks perfect!

@mscuthbert
Copy link
Member

Merging.

Thinking in the future we might need to have something like "minQuarterLength" and "maxQuarterLength" instead of a bare quarterLength idea -- but that's an idea for later.

@mscuthbert mscuthbert merged commit aacc7aa into cuthbertLab:master Feb 27, 2023
@gregchapman-dev
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscuthbert mscuthbert mscuthbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregchapman-dev @coveralls @mscuthbert