Synchronize Measure IDs on Musicxml out #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding IDs to measures in MusicXML files
|
Can you explain what this change does and add a test to show what the changed output is. THanks! (Also a small flake issue) |
|
Pinging @rigaux |
|
Sorry for the late update. So: the goal is to export measure IDs to MusicXML. Our group annotates music score, and we need to refer to measures. At the end, a measure element features an id attribute, e.g., I also added a test 'testExportIdOfMeasure ' in musicxml/test_m21ToXxml.py. It checks the existence of the 'id' attribute. |
|
just fixed the flakes myself. Will merge if passes. |
mscuthbert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding IDs to measures in MusicXML files. I added a call to _synchronizeIds(), just as it works already for other elements (eg, notes).