Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 5.0 #25

Closed
IceReaper opened this issue Oct 14, 2020 · 10 comments
Closed

.NET 5.0 #25

IceReaper opened this issue Oct 14, 2020 · 10 comments

Comments

@IceReaper
Copy link

I know, a bit early, but what are the plans on .NET 5.0?

@IceReaper
Copy link
Author

IceReaper commented Oct 15, 2020

One of the problems i found so far is, that when having net5.0 installed (ubuntu 20.04, using rider as IDE),
the compilation fails with
Sdk.targets(201, 9): [NETSDK1005] Assets file 'obj/project.assets.json' doesn't have a target for '.NETStandard,Version=v2.0'. Ensure that restore has run and that you have included '.NETStandard,Version=v2.0' in the TargetFrameworks for your project.
while using
<TargetFramework>netstandard2.0</TargetFramework>.
However when using
<TargetFramework>.NETStandard,Version=v2.0</TargetFramework>
the error is gone. The compilation itself then crashes with the message
H5 : error H5003: The SDK 'h5.Target/0.0.11500' specified could not be found.
which btw crashes with the same error using netcore 3.1 only too on my machine.

@theolivenbaum
Copy link
Collaborator

Hi @IceReaper - I think I hit that before, seems like something strange changed on the MSBuild included in the NET5.0.
What's happening is that MSBuild is not locating the nuget package that contains the project SDK target (https://www.nuget.org/packages/h5.target/) and is not restoring it either.
I'm planning to start updating our own stack to net50 quite soon, and that will start with h5. I'll post an update here as soon as I've some time to get this going!

@theolivenbaum
Copy link
Collaborator

by the way - fully uninstalling the net50 preview and keeping only the netcore3.1 sdk fixed the issue for me - you might want to give it a try!

@IceReaper
Copy link
Author

Nope, i've created another issue for now for net 3.1, so the two versions do not mix up here.

@theolivenbaum
Copy link
Collaborator

@IceReaper finally updated to net5.0 - think I found the cause of the bug when using the latest MSBuild (dotnet/msbuild#5875), and a workaround for it. Will be available soon!

@theolivenbaum
Copy link
Collaborator

@IceReaper published the updated compiler, targets, etc... now supporting NET5.0 :)

https://www.nuget.org/packages/h5-compiler
https://www.nuget.org/packages/h5.target

Let me know if you hit any issues post-update!

@IceReaper
Copy link
Author

@IceReaper finally updated to net5.0 - think I found the cause of the bug when using the latest MSBuild (dotnet/msbuild#5875), and a workaround for it. Will be available soon!

Building triggers precisely the problem you mentioned above. I tried to add the 4 workaround tags to my csproj file, but that didnt fix it.

@theolivenbaum
Copy link
Collaborator

theolivenbaum commented Nov 12, 2020 via email

@IceReaper
Copy link
Author

IceReaper commented Nov 12, 2020

<Project Sdk="h5.Target/0.0.13615"> and i did dotnet tool update --global h5-compiler --version 0.0.13622

@IceReaper
Copy link
Author

Did some more tests: It is related to #29 Without any dependency it compiles correctly. Adding another library breaks it. So i guess #25 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants