Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Suppress CUB compilation warnings #7943

Merged
merged 1 commit into from
Oct 20, 2023
Merged

MNT: Suppress CUB compilation warnings #7943

merged 1 commit into from
Oct 20, 2023

Conversation

leofang
Copy link
Member

@leofang leofang commented Oct 18, 2023

CUB utilities cub::If and cub::Equals are deprecated.

There's no need to backport this PR, as the v12 branch does not see the same CCCL headers across all CUDA versions.

@leofang
Copy link
Member Author

leofang commented Oct 18, 2023

/test mini

@asi1024 asi1024 self-assigned this Oct 18, 2023
@asi1024 asi1024 added cat:enhancement Improvements to existing features prio:medium labels Oct 18, 2023
@asi1024 asi1024 added this to the v13.0.0rc1 milestone Oct 20, 2023
@asi1024
Copy link
Member

asi1024 commented Oct 20, 2023

LGTM! Thanks!

@asi1024 asi1024 merged commit 1ef4036 into cupy:main Oct 20, 2023
9 checks passed
@leofang leofang deleted the cub_warn branch October 20, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asi1024 asi1024 asi1024 approved these changes

Assignees

@asi1024 asi1024

Labels
cat:enhancement Improvements to existing features prio:medium
Projects
None yet
Milestone
v13.0.0rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@leofang @asi1024