Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __slots__ to cupy.ndarray #7891

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Add __slots__ to cupy.ndarray #7891

merged 1 commit into from
Oct 2, 2023

Conversation

kmaehashi
Copy link
Member

Closes #7883

@takagi takagi self-assigned this Oct 2, 2023
@takagi takagi added cat:enhancement Improvements to existing features prio:medium labels Oct 2, 2023
takagi
takagi approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi
Copy link
Member

takagi commented Oct 2, 2023

/test mini

@takagi takagi enabled auto-merge October 2, 2023 05:28
@takagi takagi merged commit 80905a3 into cupy:main Oct 2, 2023
9 checks passed
@kmaehashi kmaehashi deleted the add-slots branch October 2, 2023 08:30
@kmaehashi kmaehashi added this to the v13.0.0rc1 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takagi takagi takagi approved these changes

Assignees

@takagi takagi

Labels
cat:enhancement Improvements to existing features prio:medium
Projects
None yet
Milestone
v13.0.0rc1
Development

Successfully merging this pull request may close these issues.

cupy.ndarray can be assigned with a custom attribute without an error.
2 participants
@kmaehashi @takagi