Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cupy.empty_like parameter name to prototype #7827

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix cupy.empty_like parameter name to prototype #7827

merged 1 commit into from
Aug 30, 2023

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Aug 28, 2023

For NumPy compatibility.

@takagi takagi added no-compat Disrupts backward compatibility cat:numpy-compat Follow the NumPy/SciPy spec changes prio:medium labels Aug 28, 2023
@takagi takagi self-assigned this Aug 28, 2023
@kmaehashi
Copy link
Member

/test mini

takagi
takagi approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi added this to the v13.0.0rc1 milestone Aug 29, 2023
@takagi takagi merged commit fabe739 into cupy:main Aug 30, 2023
@asi1024 asi1024 deleted the creation-paramname branch August 30, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takagi takagi takagi approved these changes

Assignees

@takagi takagi

Labels
cat:numpy-compat Follow the NumPy/SciPy spec changes no-compat Disrupts backward compatibility prio:medium
Projects
None yet
Milestone
v13.0.0rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@asi1024 @kmaehashi @takagi