Fix ROCm Dockerfile not working #7797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmaehashi
added
no-compat
|
This pull request is now in conflicts. Could you fix it @kmaehashi? 🙏 |
kmaehashi
force-pushed
the
fix-rocm-image
branch
from
613ea1c to
e3826fb
Compare
kmaehashi
force-pushed
the
fix-rocm-image
branch
from
e3826fb to
e29b3e0
Compare
|
CI passed, ready for review. |
kmaehashi
force-pushed
the
fix-rocm-image
branch
from
e29b3e0 to
6cd10d5
Compare
|
Docker image for v13.0.0b1 deployed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that ROCm Docker images not working due to missing
hipfftandLD_LIBRARY_PATH. Also, now that Ubuntu 18.04 and Python 3.8 are deprecated in CuPy v13, we have to migrate to Ubuntu 20.04 and Python 3.9 instead.To prevent the future error, I've added
RUN python3 -c "import cupy; cupy.show_config()"line to verify that CuPy can be imported.