Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port wavelets module from cusignal to cupyx.scipy.signal #7700

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Port wavelets module from cusignal to cupyx.scipy.signal #7700

merged 5 commits into from
Sep 20, 2023

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Jul 6, 2023

See #7403

@andfoy andfoy mentioned this pull request Jul 6, 2023
Open
@emcastillo emcastillo added the cat:feature New features/APIs label Jul 7, 2023
@takagi
Copy link
Member

takagi commented Jul 12, 2023

/test mini

@andfoy andfoy marked this pull request as ready for review July 13, 2023 18:21
@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

@takagi takagi changed the title [MERGE PENDING] Port wavelets module from cusignal to cupyx.scipy.signal Port wavelets module from cusignal to cupyx.scipy.signal Aug 26, 2023
@takagi
Copy link
Member

takagi commented Aug 26, 2023

/test mini

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2023

This pull request is now in conflicts. Could you fix it @andfoy? 🙏

@takagi
Copy link
Member

takagi commented Sep 19, 2023

/test full

@takagi
Copy link
Member

takagi commented Sep 19, 2023 •
edited
Loading

Full test result:
https://ci.preferred.jp/p/dashboard_by_commit_id?commit_id=f354a47bcaaefa87ec9b51da326c39e088fba0d5

@takagi takagi added this to the v13.0.0rc1 milestone Sep 19, 2023
@takagi
Copy link
Member

takagi commented Sep 19, 2023

Waiting for the test to finish.

takagi
takagi approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi merged commit 71f745a into cupy:main Sep 20, 2023
6 checks passed
@takagi
Copy link
Member

takagi commented Sep 20, 2023

Thanks, @andfoy!

@andfoy andfoy deleted the port_wavelets branch September 20, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takagi takagi takagi approved these changes

Assignees

@takagi takagi

Labels
cat:feature New features/APIs prio:medium
Projects
Signal API (CZI EOSS 5)
Status: ✅ Done
Milestone
v13.0.0rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@andfoy @takagi @emcastillo