ENH: cupyx/scipy/signal: add missing LTI format conversions #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-br
force-pushed
the
tf2zpk
branch
2 times, most recently
from
ca8757e to
fde035a
Compare
16 tasks
|
Rebased on main, this PR is ready for review. |
|
/test full |
|
This pull request is now in conflicts. Could you fix it @ev-br? 🙏 |
|
/test full |
|
This pull request is now in conflicts. Could you fix it @ev-br? 🙏 |
takagi
reviewed
Jul 12, 2023
cupyx/scipy/signal/_polyutils.py
Outdated
Comment on lines
26
to
37
| seq_of_zeros = np.linalg.eigvals(A.get()) | ||
| seq_of_zeros = cupy.asarray(seq_of_zeros) | ||
|
|
||
| dt = seq_of_zeros.dtype | ||
| a = cupy.ones((1,), dtype=dt) | ||
| for zero in seq_of_zeros: | ||
| a = cupy.convolve(a, cupy.r_[1, -zero], mode='full') | ||
|
|
||
| if issubclass(a.dtype.type, cupy.complexfloating): | ||
| # if complex roots are all complex conjugates, the roots are real. | ||
| roots = cupy.asarray(seq_of_zeros, dtype=complex) | ||
| if cupy.all(cupy.sort(roots) == cupy.sort(roots.conjugate())): | ||
| a = a.real.copy() |
There was a problem hiding this comment.
How about computing on CPU not only eigvals but also the whole of these calculations, then cupy.asarray just before return?
takagi
reviewed
Jul 12, 2023
Comment on lines
542
to
544
|
|
||
| assert_array_almost_equal(b, [-2, 1, 2, 4, 1]) | ||
| assert_array_almost_equal(a, [1, 10, 0, -10, -1]) |
There was a problem hiding this comment.
Would you remove these unreachable lines?
takagi
reviewed
Jul 12, 2023
Wrap NumPy's `linalg.eigvals` on CPU (not available in CUDA otherwise).
|
Comments addressed. |
takagi
approved these changes
Jul 14, 2023
|
/test full |
|
Thanks, @ev-br! |
|
Thank you for the reviews! (this PR and others) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross-ref gh-7403
Note that there are two utilities which delegate to NumPy on CPU,
_polyutils.rootsand.poly. Both rely onnp.linalg.eigvals, which on GPU is only available from MAGMA.this is on top of gh-7644