Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDA Python CI failure #7574

Merged
merged 2 commits into from
May 22, 2023
Merged

Fix CUDA Python CI failure #7574

merged 2 commits into from
May 22, 2023

Conversation

kmaehashi
Copy link
Member

@kmaehashi kmaehashi commented May 19, 2023

Fixes the CI failure of CUDA Python. The CUDA Python installed in the environment cannot be found during CuPy build because the build is done in isolated environment if wheel package is missing. This was a breaking change in pip v23.1.

https://pip.pypa.io/en/stable/news/#v23-1

When the wheel package is not installed, pip now uses the default build backend instead of setup.py install and setup.py develop for project without pyproject.toml.

@kmaehashi
Copy link
Member Author

/test cuda-python

@emcastillo emcastillo self-assigned this May 19, 2023
@kmaehashi kmaehashi mentioned this pull request May 19, 2023
@emcastillo emcastillo added cat:test Test code / CI prio:high labels May 19, 2023
@emcastillo emcastillo added this to the v13.0.0a1 milestone May 19, 2023
@emcastillo emcastillo added the to-be-backported Pull-requests to be backported to stable branch label May 19, 2023
@kmaehashi kmaehashi mentioned this pull request May 19, 2023
@kmaehashi
Copy link
Member Author

Test passed!

@emcastillo emcastillo merged commit 8480a6b into cupy:main May 22, 2023
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request May 22, 2023
@kmaehashi kmaehashi deleted the fix-for-pip-23.1 branch May 22, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test code / CI prio:high to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants