Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCm5.3.0 rocPrim C 14 extension requirement. #7412

Merged
merged 4 commits into from
Mar 6, 2023
Merged

ROCm5.3.0 rocPrim C 14 extension requirement. #7412

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift click to select a range
9f2ecdc
updated c extention for ROCm5.3 and above
Feb 17, 2023
9c6c778
Update cupy/_core/_cub_reduction.pyx
takagi Feb 20, 2023
aa45a8b
Merge branch 'master' into adabeyta_cub_reduce_update
AdrianAbeyta Feb 23, 2023
ff3ecb2
Merge branch 'master' into adabeyta_cub_reduce_update
AdrianAbeyta Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cupy/_core/_cub_reduction.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 28,12 @@ cdef function.Function _create_cub_reduction_function(
_kernel._TypeMap type_map, preamble, options):
# A (incomplete) list of internal variables:
# _J : the index of an element in the array

# static_assert needs at least C 11 in NVRTC
options = ('--std=c 11',)
# ROCm5.3 and above requires c 14
if runtime._is_hip_environment:
options = ('--std=c 14',)
else:
# static_assert needs at least C 11 in NVRTC
options = ('--std=c 11',)

cdef str backend
if runtime._is_hip_environment:
Expand Down