Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROCm5.3.0 rocPrim C 14 extension requirement. #7412

Merged
merged 4 commits into from
Mar 6, 2023
Merged

ROCm5.3.0 rocPrim C 14 extension requirement. #7412

merged 4 commits into from
Mar 6, 2023

Conversation

AdrianAbeyta
Copy link
Contributor

ROCm5.3.0 and above use return types are that require a minimum of C 14 extension. Fix is also backwards compatible with ROCm4.3.0.

cc: @amathews-amd @pnunna93

@emcastillo emcastillo added cat:bug Bugs cat:enhancement Improvements to existing features prio:medium and removed cat:bug Bugs labels Feb 20, 2023
@kmaehashi kmaehashi added the hip Topic: AMD ROCm / HIP label Feb 21, 2023
@github-actions
Copy link

cc/ @amathews-amd

@takagi
Copy link
Member

takagi commented Feb 21, 2023

The build-cuda pre-review test failure is due to cuquantum intersphinx inventory error. See #7417

@takagi
Copy link
Member

takagi commented Feb 21, 2023

/test jenkins

@takagi
Copy link
Member

takagi commented Feb 27, 2023

/test jenkins

@takagi
Copy link
Member

takagi commented Feb 28, 2023

Thanks, @AdrianAbeyta! I manually confirmed test_cub_reduction.py passes with this fix on ROCm 5.3 . I'm going to merge after the repo is unfrozen for the release.
(Our ROCm 5.3 CI dies on its way, so we configure it to ignore failures and just report pass)

@AdrianAbeyta
Copy link
Contributor Author

Thanks, @AdrianAbeyta! I manually confirmed test_cub_reduction.py passes with this fix on ROCm 5.3 . I'm going to merge after the repo is unfrozen for the release. (Our ROCm 5.3 CI dies on its way, so we configure it to ignore failures and just report pass)

Thanks! @takagi

@takagi takagi added this to the v13.0.0a1 milestone Mar 6, 2023
@takagi takagi merged commit f2a9d4b into cupy:main Mar 6, 2023
@kmaehashi
Copy link
Member

I guess it's better to backport this one? 😄

@takagi takagi added the to-be-backported Pull-requests to be backported to stable branch label Mar 6, 2023
@chainer-ci chainer-ci mentioned this pull request Mar 6, 2023
Merged
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Mar 6, 2023
@takagi @chainer-ci
Merge pull request cupy#7412 from AdrianAbeyta/adabeyta_cub_reduce_up…
34d6bd8 
…date

ROCm5.3.0  rocPrim C  14 extension requirement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takagi takagi takagi approved these changes

Assignees

@takagi takagi

Labels
cat:enhancement Improvements to existing features hip Topic: AMD ROCm / HIP prio:medium to-be-backported Pull-requests to be backported to stable branch
Projects
Platform Support (CZI EOSS 5)
Status: ✅ Done
Milestone
v13.0.0a1
Development

Successfully merging this pull request may close these issues.
4 participants
@AdrianAbeyta @takagi @kmaehashi @emcastillo