Grid fixes #517
Open
Grid fixes #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XLegland
commented
Apr 10, 2024
lua/modules/creations.lua
Outdated
| @@ -430,7 430,9 @@ creations.createModalContent = function(_, config) | |||
| creationsContent.node = grid | |||
|
|
|||
| creationsContent.willResignActive = function(_) | |||
| grid:cancelRequestsAndTimers() | |||
| if grid and grid.cancelRequestsAndTimers then | |||
There was a problem hiding this comment.
Note: grid may not still be there at the time willResignActive is called, as, creationsContent.node can change for something else
XLegland
force-pushed
the
xavier/grid-fixes
branch
from
cec1514
to
a204e5f
Compare
XLegland
force-pushed
the
xavier/grid-fixes
branch
from
a204e5f
to
51ab545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.