Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace tables to Number2/3`s and Rotations #465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sysfab
Copy link
Contributor

@sysfab sysfab commented Feb 11, 2024

No description provided.

@gdevillele
Copy link
Collaborator

this LGTM :)

Copy link
Collaborator

@gdevillele gdevillele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I had 1 comment about a Number2.Zero

@@ -1559,7 1559,7 @@ function createUI(system)
end

local t = Text()
t.Anchor = { 0, 0 }
t.Anchor = Number2(0, 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be Number2.Zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants