Update api.lua #403
Update api.lua #403
Conversation
Added GetUser(userid or username) and GetUserName Functions which can be added into the player module later on if needed...
There was a problem hiding this comment.
thank you for your contribution!
I understand how this can be useful, but the complex inter-dependence between getUser, getUserId and getUserName is not pretty, and will make this code difficult to evolve and maintain.
I'd like to help make things simpler.
- Can we agree that
getUsershould not depend on any other function? getUserIdandgetUserNamecould simply be "easy-to-use functions", that would usegetUserinternally.
This would make the code easy to read and understand for a new-comer and also easier to maintain, as the whole logic would be in a single function (getUser).
Let me know what you think of this :)
|
So simplifying the code by having getUser as the main function, with getUserId and getUserName as easy-to-use helper functions right? Sounds like a good approach |
@IAmMythoRED correct. I think it would be acceptable :) |
Added GetUser(userid or username) and GetUserName Functions which can be added into the player module later on if needed...