Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocm: fix federated userid #4833

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Sep 2, 2024

We now base64 encode the remote userid and provider as the local federated user id. This allows us to always differentiate them from local users and unpack the encoded user id and provider when making requests to the remote ocm provider.

related: owncloud/ocis#9927

Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some smaller findings, most of them are optimizations, LGTM 👍

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic merged commit c06d40a into cs3org:edge Sep 4, 2024
9 of 10 checks passed
@butonic butonic deleted the ocm-fix-federated-userid branch September 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants