Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-Candidate]: Fix coverage report #1213

Open
0xicingdeath opened this issue Mar 12, 2024 · 2 comments
Open

[Bug-Candidate]: Fix coverage report #1213

0xicingdeath opened this issue Mar 12, 2024 · 2 comments

Comments

@0xicingdeath
Copy link

Describe the issue:

Unclear how to read the coverage report when there is no additional information from Echidna on the state of these properties.

As an example, for the following screenshot, I'm not sure how to interpret this. What happened on the USDC.borrow for it to never be hit, but the DAI borrow could occur?

cov-output-echidna

On the flip side, how should I interpret the following? The fuzzer never showed me an assertion failure on this property, so my intuition is that it should be successful (therefore all statements running green)? - yet the assertWithMsg is showing up as red.
additional-cov-output

Code example to reproduce the issue:

Curvance :)

Version:

Echidna 2.2.3

Relevant log output:

No response

@ggrieco-tob
Copy link
Member

Do you have an screenshot on how this is covered by medusa? If the coverage looks the same, then it looks like an issue with the sourcemap, otherwise, it could be a bug in echidna.

@0xicingdeath
Copy link
Author

If I'm not mistaken, Medusa was hitting all green on the second example for setCTokenCollateralCaps_should_succeed, but was unable to hit the first example (related to repays / borrows).

Unfortunately don't have a screenshot of it though.. current version of coverage output (i.e: post-rebase) does not hit this function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants