Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Optimize JSON parsing a bit" #14804

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Revert "Optimize JSON parsing a bit" #14804

merged 1 commit into from
Jul 11, 2024

Conversation

straight-shoota
Copy link
Member

Reverts #14366

Resolves #14803

@straight-shoota straight-shoota added topic:stdlib:serialization kind:regression Something that used to correctly work but no longer works labels Jul 10, 2024
@straight-shoota straight-shoota added this to the 1.13.1 milestone Jul 10, 2024
@straight-shoota straight-shoota merged commit 2204be7 into master Jul 11, 2024
122 checks passed
@straight-shoota straight-shoota deleted the revert-14366-optimize-json branch July 11, 2024 08:19
@kuraga
Copy link

kuraga commented Jul 12, 2024

Has been #14803 test case added?

@BrewTestBot BrewTestBot mentioned this pull request Jul 12, 2024
Merged
1 task
@straight-shoota
Copy link
Member Author

Not yet. It isn't essential for the 1.13.1 release because we know it works.
Good point to add it though. Would you mind making a PR?

@kuraga
Copy link

kuraga commented Jul 15, 2024 •
edited
Loading

Sorry, no. (Don't use Crystal.)
But I see that this revert removes some specs and and doesn't add some from #14803 :) .

@Blacksmoke16 Blacksmoke16 mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees
No one assigned
Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:stdlib:serialization
Projects
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.

1.13.0 - a big problem with UTF strings after JSON.parse when some special symbols present; broken encoding
4 participants
@straight-shoota @kuraga @ysbaddaden @beta-ziliani