Fix stats and progress issues in codegen #14763
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--stats
and--progress
params had a couple issues:--threads=1
(always the case on Windows);Idea for a follow-up: the report fiber of forked codegen could set
unit.reused_previous_compilation
instead of collecting reused module names, then we wouldn't need to collect the module names into a reused array (we can trustunits
to be updated) and the#print_codegen_stats
method would count & filter has needed.