Drop Crystal::System::Socket#system_send
#14637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention of this method is equivalent to`#system_write` and the implementations are also identical. There's no need for this duplication.
straight-shoota
force-pushed
the
refactor/drop-system_send
branch
from
c0e1882
to
6e185d3
Compare
beta-ziliani
approved these changes
May 28, 2024
|
POSIX says (not just the Linux man page):
So there really isn't a difference between the implementations in Crystal since we call |
|
|
ysbaddaden
approved these changes
May 28, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this method is equivalent to
#system_writeand the implementations are also identical.There's no need for this duplication.
This does not affect the public API method
Socket#sendthough. It's not identical toSocket#writebecause the latter is buffered and it ensures the entire data is sent.Ref: crystal-lang/rfcs#7 (comment)