Do not strip the macOS target triple #14466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of Xcode 15, a new linker was introduced and with it came warnings messages as seen in #13846. It appears that the new linker is stricter in which target triples it considers valid. Specifically, it looks like the minimum deployment target is required. E.g.,
aarch64-apple-darwin23.3.0
is valid, whileaarch64-apple-darwin
is not. See #13846 (comment) for details.This PR is a follow-up of crystal-lang/distribution-scripts#296. While we have corrected the target triple for macOS
arm64
builds,x86_64
builds would still emit warnings due to us stripping the minimum deployment target inLLVM.default_target_triple
.Fixes #13846
Fixes #14052