Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wrapping arithmetic for Int::Primitive#unsafe_chr #14443

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Use wrapping arithmetic for Int::Primitive#unsafe_chr #14443

merged 1 commit into from
Apr 15, 2024

Conversation

HertzDevil
Copy link
Contributor

Resolves #14017.

@straight-shoota straight-shoota added this to the 1.13.0 milestone Apr 6, 2024
@straight-shoota straight-shoota merged commit 5d91d6b into crystal-lang:master Apr 15, 2024
58 checks passed
@HertzDevil HertzDevil deleted the perf/unsafe-chr branch April 16, 2024 11:28
@BrewTestBot BrewTestBot mentioned this pull request Jul 10, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
performance topic:stdlib:text
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Int::Primitive#unsafe_chr uses checked arithmetic
3 participants
@HertzDevil @ysbaddaden @straight-shoota