Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jekyll-action does not copy CNAME file to gh-pages #15

Closed
martinmorando opened this issue Jul 26, 2021 · 4 comments · Fixed by #16
Closed

jekyll-action does not copy CNAME file to gh-pages #15

martinmorando opened this issue Jul 26, 2021 · 4 comments · Fixed by #16
Labels
bug Something isn't working

Comments

@martinmorando
Copy link
Member

No description provided.

@martinmorando martinmorando added the bug Something isn't working label Jul 26, 2021
@martinmorando
Copy link
Member Author

It's a problem that many have encountered; there are several open and closed issues on the repository. Issue 98, opened 1 month ago, describes it, and there is a pull request (102) addressing this. On the other hand, the maintainer has stated last year that this has already been solved. Finding out if it's a repository or documentation problem.

@martinmorando
Copy link
Member Author

Built the Jekyll site in localhost using bundle exec jekyll build and found out that Jekyll was the one ignoring the CNAME file, not jekyll-action.

Solved by forcing the inclusion of CNAME file, following Jekyll configuration options.

Issue solved but, at the moment, it is not clear why some Jekyll sites must make it explicit and others not.

@viniciuspereiras
Copy link

Built the Jekyll site in localhost using bundle exec jekyll build and found out that Jekyll was the one ignoring the CNAME file, not jekyll-action.

Solved by forcing the inclusion of CNAME file, following Jekyll configuration options.

Issue solved but, at the moment, it is not clear why some Jekyll sites must make it explicit and others not.

Thanks for that, I think that worked for me 👍

@erin-bristow
Copy link

Built the Jekyll site in localhost using bundle exec jekyll build and found out that Jekyll was the one ignoring the CNAME file, not jekyll-action.

Solved by forcing the inclusion of CNAME file, following Jekyll configuration options.

Issue solved but, at the moment, it is not clear why some Jekyll sites must make it explicit and others not.

@martinmorando Also worked for me! Thanks so much, that was a frustrating issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants