Allow plain annotation seccomp-profile.kubernetes.cri-o.io for images
#7801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
release-note-none
openshift-ci
bot
added
dco-signoff: yes
openshift-ci
bot
added
the
approved
saschagrunert
force-pushed
the
seccomp-image-annotation-plain
branch
from
e11f5b5 to
ea1bcb1
Compare
kwilczynski
reviewed
Feb 20, 2024
saschagrunert
force-pushed
the
seccomp-image-annotation-plain
branch
from
ea1bcb1 to
530cdba
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7801 /- ##
==========================================
- Coverage 48.56% 48.54% -0.03%
==========================================
Files 148 148
Lines 16187 16190 3
==========================================
- Hits 7861 7859 -2
- Misses 7365 7368 3
- Partials 961 963 2 |
|
/retest |
We now additionally allow the plain `seccomp-profile.kubernetes.cri-o.io` annotation for container images, to not require users to suffix the annotation using `/POD` or a container name. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
seccomp-image-annotation-plain
branch
from
530cdba to
6bd4f68
Compare
|
@cri-o/cri-o-maintainers PTAL |
|
/retest |
|
/lgtm |
|
/approve |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
We now additionally allow the plain
seccomp-profile.kubernetes.cri-o.ioannotation for container images, to not require users to suffix the annotation using/PODor a container name.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?