Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add IS DISTINCT FROM predicate #16414

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marstein
Copy link

Added sql parsing and execution classes for the DISTINCT predicate.

Summary of the changes / Why this improves CrateDB

Implement the IS DISTINCT FROM predicate. It is just like <> but handles NULL values differently.
TODO: arrays and possibly type check.
The predicate is implemented as a Function. Please review if this is the right choice.

Checklist

  • Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
  • Updated documentation & sql_features table for user facing changes
  • Touched code is covered by tests
  • [x ] CLA is signed
  • This does not contain breaking changes, or if it does:
    • It is released within a major release
    • It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
    • It was marked as deprecated in an earlier release if possible
    • You've thought about the consequences and other components are adapted
      (E.g. AdminUI)

@crate-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@matriv
Copy link
Contributor

matriv commented Jul 29, 2024

ok to test

@mfussenegger
Copy link
Member

The predicate is implemented as a Function. Please review if this is the right choice.

Yes, implementing it internally as a scalar sounds good.

Added sql parsing and execution classes for the DISTINCT predicate.
@marstein marstein force-pushed the marstein/issue_14644_distinct_from_pred branch from ed77ed2 to ce2bf60 Compare July 29, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants