-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report: modified config file being overwritten on server restart (not reproducible) #72
Comments
I thought that when the plugin shuts down it saved the config, but it seems like this is a myth? When I tried to reproduce this I could not. When I check the current code, the config is NOT saved on shutdown, and there are only three cases when it is saved:
So the config should never overwrite except when using config commands ingame. This would make sense if it was old behavior but checking old code from Dragoboss (3.x-min) seems to imply it wasn't an issue then either. So, was this ever an issue? people certainly complained about it and I always assumed it was the case - but there is no evidence it ever was. |
Checking the code in 5.2.3 with JD (around the time of the original Issue), there is also no code forcing a save on shutdown. |
This would ease use and reduce issues like meiskam#16
The text was updated successfully, but these errors were encountered: