Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Add support for styling the tutorial popover #37

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

oubiwann
Copy link

@oubiwann oubiwann commented Dec 15, 2016

What's the issue:

Tutorial popover wasn't getting styling treatment.

What's fixed:

Now it is :-)

Screenshots:

Before:
popup-before

After:
popup-after

@cquanu cquanu added the willfix label Dec 21, 2016
@cquanu
Copy link
Owner

cquanu commented Dec 21, 2016

@oubiwann Hi, thanks for helping! The infobar is already fixed in v2.6.0 release (Haven't push it). However, you can style the TutorialPopover but some color need to be changed.

@cquanu
Copy link
Owner

cquanu commented Dec 21, 2016

@oubiwann Can you try this color? Background: #1a2632, btn #243447

@oubiwann oubiwann changed the title Add support for styling the branch infobar Add support for styling the tutorial popover Dec 24, 2016
Also:
* Moved `.TutorialPopover` into its own section
* Removed `.branch-infobar`, since that work has been done already in a different branch
@oubiwann
Copy link
Author

I've changed the background color; trying to figure out how to get the tutorial messages back so that I can test the button color ...

@oubiwann
Copy link
Author

Hrm, for the popovers and dropdowns, a caret is used. When the popover/dropdown background color is different from the page background, this caret (or wedge) is visiable; when #1a2632 is used instead, you can't see it :-(

Attaching screenshot:

screenshot from 2016-12-24 15-09-03

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants