Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multimodal support #1818

Merged
merged 4 commits into from
Oct 2, 2024
Merged

feat: add multimodal support #1818

merged 4 commits into from
Oct 2, 2024

Conversation

mlong93
Copy link

@mlong93 mlong93 commented Oct 2, 2024

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

Additional context
Add any other context or screenshots about the PR here.

* new representation for messages that includes text and images
* updated client to handle new message representation in chat completions
* test cases in `project.py`
* Changed schemas to accept `ContentPart`
* Need to fix llm_api_tools.py (TODO), where inner thoughts clash with model output in 4o models
@cpacker cpacker self-requested a review October 2, 2024 04:08
@cpacker cpacker changed the base branch from main to multimodal October 2, 2024 04:09
Copy link
Owner

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging into feature branch

@cpacker cpacker merged commit f6e8107 into cpacker:multimodal Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants