R4R: Fix tally result #2861
Closed
R4R: Fix tally result #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
27 tasks
alexanderbez
suggested changes
Nov 19, 2018
| // create SubmitProposal TX | ||
| resultTx = doVote(t, port, seed, name, password, addr, proposalID) | ||
| resultTx = doVote(t, port, seed, name, password, addr, proposalID, option.String()) | ||
| tests.WaitForHeight(resultTx.Height 1, port) | ||
|
|
||
| vote := getVote(t, port, proposalID, addr) | ||
| require.Equal(t, proposalID, vote.ProposalID) | ||
| require.Equal(t, gov.OptionYes, vote.Option) |
There was a problem hiding this comment.
Why not use option here since we already have a variable for it.
| tally := proposal.GetTallyResult() | ||
| switch { | ||
| case option == OptionYes: | ||
| tally.Yes = tally.Yes.Sub(sdk.NewDec(1)) |
There was a problem hiding this comment.
Can we use sdk.OneDec in these cases?
| tally := proposal.GetTallyResult() | ||
| switch { | ||
| case option == OptionYes: | ||
| tally.Yes = tally.Yes.Add(sdk.NewDec(1)) |
| if oldVote.Option != option { | ||
| // Case 1.1: new option is different than the previous one | ||
| keeper.decreaseProposalTally(ctx, proposal, oldVote.Option) | ||
| keeper.SetProposal(ctx, proposal) |
There was a problem hiding this comment.
Why are we setting the proposal twice?
|
Closing per discussion between @fedekunze and @sunnya97 that resolves this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2859
__
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: