-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version and amend notes to include latest PRs #4634
Conversation
Signed-off-by: Miek Gieben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice.
notes/coredns-1.8.4.md
Outdated
@@ -32,15 36,18 @@ Yury Tsarev. | |||
|
|||
## Noteworthy Changes | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM some small fixes, and also etcd is releasing 3.5 this week, they just dropped 3.5.0beta. Probably should at least bump to latest beta ...
Clarification - they started the release process this week, code freeze yesterday. Reading the 3.5.0 beta CHANGELOG, looks like the final release is slated for June, which is a ways off. |
Given that #4621 will require updates in almost all external plugins, should we bump the minor version? I.e. to v1.9.0 instead of v1.8.4. |
Co-authored-by: Chris O'Haver <[email protected]>
Co-authored-by: Chris O'Haver <[email protected]>
Co-authored-by: Chris O'Haver <[email protected]>
Co-authored-by: Chris O'Haver <[email protected]>
Signed-off-by: Miek Gieben <[email protected]>
* Bump version and amend notes to include latest PRs Signed-off-by: Miek Gieben <[email protected]> * Update notes/coredns-1.8.4.md Co-authored-by: Chris O'Haver <[email protected]> * Update notes/coredns-1.8.4.md Co-authored-by: Chris O'Haver <[email protected]> * Update notes/coredns-1.8.4.md Co-authored-by: Chris O'Haver <[email protected]> * Update notes/coredns-1.8.4.md Co-authored-by: Chris O'Haver <[email protected]> * Remove newline and set data anew Signed-off-by: Miek Gieben <[email protected]> Co-authored-by: Chris O'Haver <[email protected]> Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Miek Gieben [email protected]