Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version and amend notes to include latest PRs #4634

Merged
merged 6 commits into from
May 28, 2021
Merged

Conversation

miekg
Copy link
Member

@miekg miekg commented May 18, 2021

Signed-off-by: Miek Gieben [email protected]

Copy link
Collaborator

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice.

@@ -32,15 36,18 @@ Yury Tsarev.

## Noteworthy Changes


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline?

Copy link
Member

@chrisohaver chrisohaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM some small fixes, and also etcd is releasing 3.5 this week, they just dropped 3.5.0beta. Probably should at least bump to latest beta ...

notes/coredns-1.8.4.md Outdated Show resolved Hide resolved
notes/coredns-1.8.4.md Outdated Show resolved Hide resolved
notes/coredns-1.8.4.md Outdated Show resolved Hide resolved
@chrisohaver
Copy link
Member

... etcd is releasing 3.5 this week ...

Clarification - they started the release process this week, code freeze yesterday. Reading the 3.5.0 beta CHANGELOG, looks like the final release is slated for June, which is a ways off.

notes/coredns-1.8.4.md Outdated Show resolved Hide resolved
@chrisohaver
Copy link
Member

chrisohaver commented May 24, 2021

Given that #4621 will require updates in almost all external plugins, should we bump the minor version? I.e. to v1.9.0 instead of v1.8.4.

notes/coredns-1.8.4.md Outdated Show resolved Hide resolved
notes/coredns-1.8.4.md Show resolved Hide resolved
notes/coredns-1.8.4.md Show resolved Hide resolved
miekg and others added 5 commits May 28, 2021 12:06
@miekg miekg merged commit 053c4d5 into master May 28, 2021
@miekg miekg deleted the version-and-notes branch May 28, 2021 10:14
jinglina pushed a commit to jinglina/coredns that referenced this pull request Dec 23, 2021
* Bump version and amend notes to include latest PRs

Signed-off-by: Miek Gieben <[email protected]>

* Update notes/coredns-1.8.4.md

Co-authored-by: Chris O'Haver <[email protected]>

* Update notes/coredns-1.8.4.md

Co-authored-by: Chris O'Haver <[email protected]>

* Update notes/coredns-1.8.4.md

Co-authored-by: Chris O'Haver <[email protected]>

* Update notes/coredns-1.8.4.md

Co-authored-by: Chris O'Haver <[email protected]>

* Remove newline and set data anew

Signed-off-by: Miek Gieben <[email protected]>

Co-authored-by: Chris O'Haver <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants