-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate use of cfg(accessible) #1
Comments
You can also have currently-invalid cfgs in the conditional cfg. Are there any cfgs that are currently unstable? |
|
@roblabla That compiles on release mode but not debug, so I think that path will work. In case the playground somehow breaks: #[cfg_attr(debug_assertions, cfg(rustdoc))]
#[cfg(debug_assertions)]
fn func() {
println!("{}", "hi");
} |
...wait, |
Assuming that Rust 1.xx.0 adds |
Let"s keep this open while waiting for cfg(accessible). Issues should only be closed once they"ve been completed (either as "won"t ever happen" or "this is implemented in master"). |
Instead of version_check, we might be able to use
cfg(accessible)
from rust-lang/rfcs#2523. I see two upsides to this:cfg(accessible)
(need to investigate if we can conditionally remove the build script).The text was updated successfully, but these errors were encountered: