Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(welcome button): align text to vertical center #585

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix(welcome button): align text to vertical center #585

merged 1 commit into from
Jul 15, 2024

Conversation

nekonado
Copy link
Contributor

Description

  • Adjusted the welcome button so that the text is aligned to the vertical center, improving visual appearance.

Motivation

  • By merging this Pull Request, the first view of pages in languages such as Chinese and Japanese, which use characters that are displayed larger than alphabets, will appear more aesthetically pleasing.
  • Moreover, it is unlikely to negatively impact the UI of pages in other languages, such as English, making this change beneficial overall.

Screenshots

  • Please refer to the screenshots below for a comparison of the UI differences.
UI differences
Before After
image image
image image
image image

@nekonado
fix(welcome button): align text to vertical center
def9a37 
Adjusted the welcome button so that the text is aligned to the vertical center, improving visual appearance.
@nekonado
Copy link
Contributor Author

Hi @stevemao, @damianopetrungaro, @ghermeto, @lorenzodianni, @tunnckoCore, @zeke, Thank you very much for merging my previous PR (#576 )! I really appreciate your support.
When you have a moment, could you please review this PR as well? Your feedback would be greatly appreciated.

@stevemao stevemao merged commit ad58fca into conventional-commits:master Jul 15, 2024
4 checks passed
@nekonado nekonado deleted the fix/adjust-welcome-button-ui branch July 15, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekonado @stevemao