Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite summary in simple English #559

Closed
wants to merge 1 commit into from

Conversation

abitrolly
Copy link

I couldn"t read the specification right and had to spent some time in fixing non-existing problem. :D

So I decided to rewrite the summary in Simple English so that next time I won"t have this problem (hopefully).

which makes it easier to write automated tools on top of.
This convention dovetails with [SemVer](http://semver.org),
The Conventional Commits specification is a simple set of rules for commit messages.
It helps create an explicit commit history, and makes writing automation tools easier.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“helps to create”

Comment on lines -21 to 26
<type>[optional scope]: <description>
<type>([scope])[!]: <description>

[optional body]
[body]

[optional footer(s)]
[footer(s)]
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I those add a lot of value, why are we removing them?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because by convention <> and [] already mark fields as required or optional. In this particular case it is not the specification that can be parsed or produced automatically, so the <> and [] can be removed if you prefer word descriptions.

Copy link
Member

@damianopetrungaro damianopetrungaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before jumping in opening a PR, I suggest you open an Issue and see how many people are having the same problem you described.

Merging this as it is would most likely add a few drawbacks.

@damianopetrungaro
Copy link
Member

I"ll close this for the moment @abitrolly , but we manage to acknowledge more users feel the same we can def. revisit this

@abitrolly
Copy link
Author

@damianopetrungaro that"s completely slipped off my radar. I don"t think the other people. who can not read as me, go as far as write the issue. A year ago it was just easier for me to hit the edit button. Now 10 months later I rather would use llama3 or qwen to simplify the whole text..

@einaren
Copy link

einaren commented Oct 23, 2024

@damianopetrungaro I subsribed to this PR a long time ago, hoping it would pass as I agree the wording could be simplified. I see you want Issues before PRs. Perhaps you then want to update contributing?

@abitrolly
Copy link
Author

@damianopetrungaro oh, I see "Allow edits by maintainers" was missing, but now I"ve set it, so feel free to reopen, edit and rephrase as suitable and merge it. We may always revert if everything goes wrong. )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants