Removed Nette\Object #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@f3l1x Do you approve this if it is all right? :) I dont want to hurry, but we're waiting for this in our company. |
f3l1x
reviewed
Feb 22, 2018
| @@ -126,7 126,7 @@ protected function buildRecurrentPayment(RecurrentPayment $payment, $channel) | |||
| $payment->getRecurrencePeriod(), | |||
| $channels, | |||
| $channel, | |||
| $this->gopay->config->getGopaySecretKey(), | |||
| $this->gopay->getConfig()->getGopaySecretKey(), | |||
There was a problem hiding this comment.
Well, I like this syntax. Could you preserve Nette\Object -> SmartObject for that? Similar for soap.
f3l1x
reviewed
Feb 22, 2018
src/Gopay/Gopay.php
Outdated
| { | ||
|
|
||
| use Nette\SmartObject; |
|
It's great, one last thing. Add PHP 7.2 to Travis check. |
|
Thanks. |
|
Bumped in v3.2.0 |
|
How long it usually take to reflect a new version on packagist? No new version there, it is weird. |
|
It's there. I've had to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Nette\Object for support of PHP 7.2