chore(cleanup): Add prettier and remove babel #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 27, 2019 09:21
| url: `https://api.github.com/repos/${repo}/releases/latest` | ||
| }) | ||
| ctx.latestReleaseInfo = response.data | ||
| } catch (err) { |
| }) | ||
| ctx.latestReleaseTarballStream = response.data | ||
| } catch (err) { | ||
| throw err |
If we use chore we won't have a new release with the changes. However, one can argue that this is not a suer facing release and it can wait to another proper release |
Yeah, that's my point @Khaledgarbaya. Not to have a release based on changes that aren't user-facing and it's really a chore. |
jroehl
changed the title
phoebeschmidt
approved these changes
Sep 27, 2019
makinwab
approved these changes
Sep 27, 2019
Khaledgarbaya
approved these changes
Sep 27, 2019
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove transpilation and introduce prettier.
Description
Motivation and Context
To simplify keeping dependencies up to date and remove unnecessary complexity from the build/lint/develop process, we can remove babel, a custom eslint config from the codebase. Instead we can rely on an opinionated linter (
prettier) and use the built-in features of node >= 8, getting rid of the transpilation process.Todos
Screenshots (if appropriate):