-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change mount.rs
find_parent_mount from pub to private
#2814
Comments
Note that this change would likely be a breaking change, so PR should be labeled accordingly, along with changelog info. |
@Mossaka Do you use this function in runwasi? |
No, it's not used in runwasi. However, I would be more careful in making breaking changes if we don't have a strong motivation. |
Thanks every body suggestion, we can hold this issue, keep watch, and then decide how to resolve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current
find_parent_mount
method is only inimpl Mount
use, we can change toprivate fn
frompub fn
.youki/crates/libcontainer/src/rootfs/mount.rs
Line 614 in 4d4ce7c
The text was updated successfully, but these errors were encountered: