Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): adding certificates into a podman machine #8712

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

shipsing
Copy link
Contributor

@shipsing shipsing commented Sep 3, 2024

Signed-off-by: Shipra Singh [email protected]

What does this PR do?

Documenting the procedure to add certificates into a Podman machine

Screenshot / video of UI

PR preview: https://66e019adf4514f54bb783c38--podman-desktop-pr.netlify.app/docs/podman/adding-certificates-to-a-podman-machine

What issues does this PR fix or reference?

#7732

How to test this PR?

  • Tests are covering the bug fix or the new feature

@shipsing shipsing requested review from slemeur, cdrage, benoitf and a team as code owners September 3, 2024 05:55
@shipsing shipsing requested review from feloy, axel7083 and gastoner and removed request for a team September 3, 2024 05:55
@shipsing
Copy link
Contributor Author

shipsing commented Sep 3, 2024

Thank you, @feloy, for your suggestions. I have incorporated them.

@gastoner
Copy link
Contributor

gastoner commented Sep 3, 2024

I would add the "header" like [root@localhost anchors]# exit instead of just # exit. It looks to me more rigid, and I think that the user can orient better with the "header".

Probably I miss some understanding about the Windows/Linux/MacOS machines, If I would guess I would say that the core is the same in all of them (Linux), so only command that is executed in host (Windows/Linux/Mac) is the podman machine ssh which is identical in W/L/M and then you will run the "Windows guide" inside the (Linux) podman machine

Someone with deeper knowledge, please share your thoughts!

Otherwise Looks Good!

Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to using tabs for separate instructions for macOS and Windows, see this example: https://podman-desktop.io/docs/podman/gpu and how we have it separated

@shipsing
Copy link
Contributor Author

shipsing commented Sep 5, 2024

Thank you @gastoner for your suggestion.
In here, the path for placing certificates is fixed, but at times users might require to run certain commands from their choice of path. So, implementing this suggestion in all those scenarios would be difficult or everytime we would need to put a note that you can change the path from where this command is being run based on your needs.
Secondly, we would also require to implement this change all across the doc to maintain consistency.

@shipsing
Copy link
Contributor Author

@cdrage @gastoner, Could you please verify the changes and provide an ACK over the PR? Thanks

@gastoner
Copy link
Contributor

Yes I've tried the whole process:

[egasta@RH-PW00PEZR podman-desktop (refactor_utils_is_dark_mode *%)]$ podman machine ssh machine
...
core@localhost:~$ sudo su -
root@localhost:~# cd /etc/pki/ca-trust/source/anchors/
root@localhost:/etc/pki/ca-trust/source/anchors# curl -k -o cert.pem https://XXX.pem
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2297 100 2297 0 0 5657 0 --:--:-- --:--:-- --:--:-- 5671
root@localhost:/etc/pki/ca-trust/source/anchors# ls
cert.pem
root@localhost:/etc/pki/ca-trust/source/anchors# update-ca-trust
root@localhost:/etc/pki/ca-trust/source/anchors# exit
logout
core@localhost:~$ exit
logout
[egasta@RH-PW00PEZR podman-desktop (refactor_utils_is_dark_mode *%)]$

  1. And I think that maybe the point 6 and 7 is switched? Because first exit will exit the "root" and the second exit will exit the machine
  2. Maybe I would also add to the first point podman machine ssh the name => podman machine ssh <machine_name>

Otherwise LGTM! Great Job!

@shipsing
Copy link
Contributor Author

@gastoner, fixed your suggestions. Thanks

@shipsing
Copy link
Contributor Author

@cdrage, Can i get an approval on this PR? Merging is blocked for me. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants