-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(website): adding certificates into a podman machine #8712
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Shipra Singh <[email protected]>
Signed-off-by: Shipra Singh <[email protected]>
Signed-off-by: Shipra Singh <[email protected]>
Signed-off-by: Shipra Singh <[email protected]>
Thank you, @feloy, for your suggestions. I have incorporated them. |
I would add the "header" like Probably I miss some understanding about the Windows/Linux/MacOS machines, If I would guess I would say that the core is the same in all of them (Linux), so only command that is executed in host (Windows/Linux/Mac) is the Someone with deeper knowledge, please share your thoughts! Otherwise Looks Good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to using tabs for separate instructions for macOS and Windows, see this example: https://podman-desktop.io/docs/podman/gpu and how we have it separated
Signed-off-by: Shipra Singh <[email protected]>
Signed-off-by: Shipra Singh <[email protected]>
Signed-off-by: Shipra Singh <[email protected]>
Signed-off-by: Shipra Singh <[email protected]>
Thank you @gastoner for your suggestion. |
Signed-off-by: Shipra Singh <[email protected]>
Signed-off-by: Shipra Singh <[email protected]>
Signed-off-by: Shipra Singh <[email protected]>
Yes I've tried the whole process:
Otherwise LGTM! Great Job! |
Signed-off-by: Shipra Singh <[email protected]>
@gastoner, fixed your suggestions. Thanks |
@cdrage, Can i get an approval on this PR? Merging is blocked for me. Thanks |
Signed-off-by: Shipra Singh [email protected]
What does this PR do?
Documenting the procedure to add certificates into a Podman machine
Screenshot / video of UI
PR preview: https://66e019adf4514f54bb783c38--podman-desktop-pr.netlify.app/docs/podman/adding-certificates-to-a-podman-machine
What issues does this PR fix or reference?
#7732
How to test this PR?