Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to manually refresh the catalog #8340

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Aug 2, 2024

What does this PR do?

Add an option to manually refresh the catalog (and see the error in case of error)

Screenshot / video of UI

image

Also add an empty screen section
image

What issues does this PR fix or reference?

fixes #5349

How to test this PR?

  • Tests are covering the bug fix or the new feature

@benoitf benoitf requested a review from a team as a code owner August 2, 2024 13:27
@benoitf benoitf requested review from dgolovin, gastoner and SoniaSandler and removed request for a team August 2, 2024 13:27
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by starting podman-desktop without internet

Got the error when still offline, however nothing happens when clicking on refresh when I have internet

Screencast.from.2024-08-02.15-32-16.mp4

The catalog seems to have been fetched on the backend side

image

Sidenote

We should have the same button on the kubernetes screen, I often force context switch when I start my kind cluster because it is too long to refresh automatically, I will open an issue

@benoitf
Copy link
Collaborator Author

benoitf commented Aug 2, 2024

@axel7083 good catch. The store was not receiving an order to be updated. Fixed

Copy link
Contributor

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extension catalog download time out on a regular basis
3 participants