feat: improved environment column (provider info) #8303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the environment columns all show a ProviderInfo that only says 'Podman', 'Docker', or 'Kubernetes'. When you have multiple Podman instances or switch Kubernetes contexts it would be more useful to provide some more information. This PR makes changes to both environments: - For Kubernetes contexts, use the name of the provider (e.g. Kind or OpenShift Local) if we can find it based on the current context endpoint (since we only support the current context). - For container providers, use the name of the provider, e.g. 'Podman'. If the provider has more than one connection (e.g. I have two Podman machines), use the name of the connection (machine). Part of containers#8281. Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
requested review from
cdrage and
feloy
and removed request for
a team
axel7083
reviewed
Jul 31, 2024
|
I don't think it'll handle all cases and how it can handle long names properly probably the information should be on the hover/tooltip rather than the field itself |
I really like having this information available directly without hovering. I think an overflow nicely set handle it well
|
benoitf
reviewed
Jul 31, 2024
|
This doesn't show any difference, between providers that are "local" and providers that are "remote" i.e. it relies on naming the machines or the instances in some sensible way, to be able to tell them apart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, the environment columns all show a ProviderInfo that only says 'Podman', 'Docker', or 'Kubernetes'. When you have multiple Podman instances or switch Kubernetes contexts it would be more useful to provide some more information.
This PR makes changes to both environments:
Screenshot / video of UI
Before:
After:
What issues does this PR fix or reference?
Part of #8281.
How to test this PR?
Try in a simple setup with just one machine/Kubernetes context, as well as with multiple machines, switching context, etc.
Would especially like some feedback from people who have tried the Podman remote support.