Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): kubernetes contexts e2e tests #7843

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rostalan
Copy link
Contributor

@rostalan rostalan commented Jun 27, 2024

What does this PR do?

Creates new page models for "Kubernetes Contexts" and for "Preferences".
Implemented new test covering the switching and deletion contextts.

Screencast of this PR

Screenshot / video of UI

Peek.2024-06-27.20-03.webm

What issues does this PR fix or reference?

Implements #6789.

How to test this PR?

Run yarn test:e2e

  • Tests are covering the bug fix or the new feature

@rostalan rostalan requested a review from a team June 27, 2024 17:56
@rostalan rostalan force-pushed the kube-context branch 2 times, most recently from c4f2acd to 890eab4 Compare July 16, 2024 09:15
@rostalan rostalan marked this pull request as ready for review July 16, 2024 09:47
@rostalan rostalan requested review from benoitf and a team as code owners July 16, 2024 09:47
@rostalan rostalan requested review from jeffmaury and lstocchi and removed request for a team July 16, 2024 09:47
@@ -0,0 1,45 @@
apiVersion: v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add copyright.

await this.kubePathInput.evaluate(node => node.removeAttribute('readonly'));
await this.kubePathInput.evaluate(node => node.removeAttribute('disabled'));
await this.kubePathInput.selectText();
await this.kubePathInput.fill(pathToKube);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an assert that text/value is in the locator. we do not click or anything to apply it. so at least that would do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants