Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix persistent flag conflict #1349

Closed
wants to merge 1 commit into from
Closed

fix persistent flag conflict #1349

wants to merge 1 commit into from

Conversation

fahedouch
Copy link
Member

@fahedouch fahedouch commented Sep 2, 2022 •
edited
Loading

point to cobra and pflag forks
spf13/pflag#357
spf13/cobra#1795

fixing #1334
Signed-off-by: fahed dorgaa [email protected]

AkihiroSuda
AkihiroSuda reviewed Sep 3, 2022
View reviewed changes
cmd/nerdctl/main.go Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda reviewed Sep 3, 2022
View reviewed changes
cmd/nerdctl/main.go Outdated Show resolved Hide resolved
@fahedouch fahedouch marked this pull request as draft September 5, 2022 09:04
@fahedouch fahedouch force-pushed the fix-persistent-flag-conflict branch from bb16f0c to 61fff09 Compare September 5, 2022 22:42
@fahedouch fahedouch marked this pull request as ready for review September 5, 2022 22:42
@fahedouch fahedouch force-pushed the fix-persistent-flag-conflict branch from 88b3fdd to 419a0f2 Compare September 5, 2022 22:46
@fahedouch
fix persistent flag conflict
709a725 
Signed-off-by: fahed dorgaa <[email protected]>
@fahedouch fahedouch force-pushed the fix-persistent-flag-conflict branch from 419a0f2 to 709a725 Compare September 5, 2022 22:46
@fahedouch fahedouch added the area/cobra cobra cmd label Sep 5, 2022
@AkihiroSuda AkihiroSuda marked this pull request as draft September 5, 2022 23:22
@fahedouch
Copy link
Member Author

fahedouch commented Sep 10, 2022 •
edited
Loading

close in favor of #1375

@fahedouch fahedouch closed this Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

Assignees
No one assigned
Labels
area/cobra cobra cmd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fahedouch @AkihiroSuda