Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate AzureKeyVaultConfigStore to @configu/integrations #540

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Migrate AzureKeyVaultConfigStore to @configu/integrations #540

merged 5 commits into from
Oct 13, 2024

Conversation

gagandeepp
Copy link
Contributor

@gagandeepp gagandeepp commented Oct 10, 2024 •
edited
Loading

Closes #511

@gagandeepp gagandeepp requested review from rannn505 and a team as code owners October 10, 2024 10:50
@gagandeepp
Copy link
Contributor Author

@rannn505 Please review

@gagandeepp
Copy link
Contributor Author

@rannn505 Please review

@gagandeepp
Copy link
Contributor Author

@davidmeirlevy please review

@RichardAkman
Copy link
Contributor

@gagandeepp, seems like you resolved everything but one thing is missing. Please run pnpm i on the repository root folder to ensure the pnpm-lock.yaml is updated, this is a requirement to pass the CI.

RichardAkman
RichardAkman approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@RichardAkman RichardAkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll handle the update of the lock file.

@RichardAkman RichardAkman merged commit 6f7706f into configu:main Oct 13, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardAkman RichardAkman RichardAkman approved these changes

@rannn505 rannn505 Awaiting requested review from rannn505 rannn505 is a code owner

Assignees

@gagandeepp gagandeepp

Labels
community hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate AzureKeyVaultConfigStore to @configu/integrations
2 participants
@gagandeepp @RichardAkman