Implement CSV ConfigFormatter #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "typescript": "^5.6.2", | ||
| "zx": "8.1.8" | ||
| }, | ||
| "dependencies": { | ||
| "csv-stringify": "6.5.1" |
There was a problem hiding this comment.
this repository acts as a monorepo.
please install this package directly on the relevant internal package that uses it.
There was a problem hiding this comment.
@davidmeirlevy this is currently installed in the lib package. By the relevant package do you mean the integrations package that I must move the feat to according the to new version?
There was a problem hiding this comment.
@ovindu-a i guess @davidmeirlevy ment the @configu/lib package
davidmeirlevy
requested changes
Oct 7, 2024
|
Sure @davidmeirlevy, I will make the changes as mentioned. |
|
@ovindu-a thanks for the great effort i will merge it an fix the dependency location myself |
|
Sure @rannn505, let me know if there are any more issues I can work on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #462
I have implemented CSV formatter as requested in the above issue.